Update unicode_ascii.rakudoc #4553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regularise X<> in headings Placing the term whitespace outside the `X<>` has an effect on the rendering in the title. It seems to be the only example of this form in a heading in all the Raku/docs/doc repo. Tested with `rak '/^\=head\d\s+X\<\| /' raku-docs` (**raku-docs** is a local clone of Raku/docs)
|
@dontlaugh @coke I'm finding these subtle outliers as I'm refactoring the generation of secondaries, search, routines page, types page and the index - they were all jumbled together in an ad hoc fashion. |
|
Should this be a style we check for and disallow in a test, or will it eventually cause a compilation error? |
|
Yes I think this form (an empty ` X<>` together with chars outside the
`X<>`) in a header! should be disallowed. The reason is that it doesn't
achieve what is intended. IMHO However both are correct forms and so will
always compile.
…On Sat, 18 Jan 2025, 19:34 Will Coleda, ***@***.***> wrote:
Should this be a style we check for and disallow in a test, or will it
eventually cause a compilation error?
—
Reply to this email directly, view it on GitHub
<#4553 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACYZHAJ45D5QLD6ANVWOXL2LKUDLAVCNFSM6AAAAABVNQNH7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJZHA2TAOJZGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@finanalyst will you add that style check to this PR? then we can approve this |
|
@dontlaugh Sorry I missed your feedback. |
|
@finanalyst That's okay. We don't need to hold back this PR. |
dontlaugh
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Regularise X<> in headings
Placing the term whitespace outside the
X<>has an effect on the rendering in the title. It seems to be the only example of this form in a heading in all the Raku/docs/doc repo. Tested withrak '/^\=head\d\s+X\<\| /' raku-docs(raku-docs is a local clone of Raku/docs)Solution provided
Placing the term whitespace inside the
X<>